search

osscameroon / js-generator

Generates JavaScript from HTML
https://osscameroon.github.io/js-generator/
MIT License
18 stars 14 forks source link

Added custom Banner #254

Closed ParthAdhana closed 11 months ago

ParthAdhana commented 11 months ago

This PR addresses "Using Spring Boot Custom Banners #252" issue . The custom Banner is present in Banner.txt file along with application.yaml file

Closes #252

FanJups commented 11 months ago

Hi @ParthAdhana , I am so happy for your contribution. We will review it together and merge asap 😊💯

ParthAdhana commented 11 months ago

Hi @FanJups , Thanks for the kind word , please let me know if any corrections are to be made in this PR :)

FanJups commented 11 months ago

Hi @FanJups , Thanks for the kind word , please let me know if any corrections are to be made in this PR :)

https://www.baeldung.com/spring-boot-custom-banners

@ParthAdhana thanks again for your contribution. You got the idea but there are some changes to do. What is the purpose of .history folder ?

First, just add this property into application.yaml of slim api and slim cli

spring:
  banner:
    location: classpath:/banner.txt

Then, create src/main/resources/banner.txt in these 2 modules.

Go to https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-API to get the content for api and https://patorjk.com/software/taag/#p=display&f=Big&t=JSGENERATOR-CLI for cli modules.

Copy and paste the result into banner.txt of each module.

How to know if everything work well ?

Please, make sure you are using Maven 4 then just run these commands for api spring-boot:run --projects jsgenerator-api and cli spring-boot:run --projects jsgenerator-cli at the root directory js-generator. Then, just pay attention to console output.

Note: Next time, don't use the main branch for PR, it is not a good practice. Instead, create another feature branch on your fork and use that one. This link will give you more details

https://stackoverflow.com/questions/48434973/should-i-create-a-branch-of-the-fork-while-creating-pr-for-apache-kafka#:~:text=Whenever%20you%20begin%20work%20on,for%20every%20task%20you%20complete.

FanJups commented 11 months ago

@ParthAdhana any issues ? I am here to help.

ParthAdhana commented 11 months ago

@FanJups I have created another PR and this time from a feature branch can you please check that one out, #256 I am not sure if that is the correct way of doing that , as it is still my first PR.