search

ossf / fuzz-introspector

Fuzz Introspector -- introspect, extend and optimise fuzzers
https://fuzz-introspector.readthedocs.io
Apache License 2.0
358 stars 53 forks source link

Add mypy to the webapp #1560

Open DavidKorczynski opened 3 weeks ago

DavidKorczynski commented 3 weeks ago

We recently had a regression that caused the webapp to fail after a sequence of API calls were made: https://github.com/ossf/fuzz-introspector/pull/1559

I think we could have caught this using strict type checking since https://github.com/ossf/fuzz-introspector/blob/886fdbb761feb602a333ea0a05e28c5c693f3ee3/tools/web-fuzzing-introspection/app/webapp/routes.py#L1027 would have been caught by type analysis, as the line appends an element of type list, which is not the type of element the list holds.

DavidKorczynski commented 3 weeks ago

@arthurscchan

arthurscchan commented 3 weeks ago

The CI has discovered serveral existing problems and bugs in the web apps and they have been fixed before introducing this new CI. The fixes for these problems and bugs are merged in PRs #1564 #1565 #1566 #1567 #1568 #1569 #1570 #1577.