Closed hythloda closed 1 month ago
@oliverchang has the project had enough time to review the charter? Any thoughts or changes needed? We are hoping to close out the charter.
Any other concerns with the charter that stops us from approval?
I have no issue with this 👍🏻
need to have date charter was adopted entered prior to merging
Working with LF legal, they don't want this charter merged, so there is no date. We are using GitHub in hopes of getting the approval and adopting the date of the last approval, and then we can upload it as a PDF. The reason for this is that when it isn't a pdf people have made changes to charters in other groups and then there is the official charter stored with legal and a different one on GitHub.
Apologies for the delay, I thought I already approved it in https://github.com/ossf/osv-schema/pull/228#pullrequestreview-1999964957
Apologies for the delay, I thought I already approved it in #228 (review)
You indeed have. Do we need approval from @rsc to close it out or can I move this to closed?
LGTM thanks.
I am closing this PR as I do not have write access any longer to make the needed changes. The charter that should be added is here: OSV Schema Technical Charter.pdf
This PR resolves #224 The mission specifically needs review.