Closed tom--pollard closed 3 years ago
Looking at @bugsnag/electron
in the snapshot above it seems that the pubDate in this rss feed matches the latest
tag whereas it is included in the updates feed since there is a NEW version published with label next
17 minutes ago (from time of writing this).
The fetchVersionInformation()
function grabs the latest
tag from the package specific api endpoint currently which is indeed a problem if that isn't the version we've been notified of via the firehose feed.
This raises a separate issue of old
npm packages being published via package-feeds when a next
version is updated and we publish the latest
which could be from several weeks ago.
In reverse of that ngx-jira-issue-collector
pubDate
matches that of it's dist-tags
previous release-8.x
, and latest
is in fact the newest tag https://www.npmjs.com/package/ngx-jira-issue-collector?activeTab=versions
"dist-tags":{"latest":"9.0.3","release-8.x":"8.0.1"}
So we'd (when latest is the actual tag that updated) end up publishing the 'correct' latest version
, however the created_date
would be that of the older dist-tag. This is appose to (when latest isn't that tag that updated) the @bugsnag/electron
example where the version
and create_date
are correct for latest, all be it for an old release which may have already been tested and which is not the version that caused the entry.
There is a "time" field provided:
time":{"created":"2020-05-13T12:30:02.074Z","9.0.0":"2020-05-13T12:30:02.334Z","modified":"2021-05-07T12:17:47.640Z","9.0.1":"2020-05-13T13:12:59.225Z","8.0.1":"2020-05-13T15:21:02.565Z","9.0.2":"2020-06-02T08:37:26.504Z","9.0.3":"2021-05-07T12:17:45.447Z"
We could assume the last entry in the node is that of the event which triggered the rss entry, and use that as the version
& created_date
? A caveat there is if the same package is included multiple times in a single polls results, as both would resolve down to the same version.
For a given snapshot of the npm endpoint https://registry.npmjs.org/-/rss the assumption that entries are in chronological order to their respective
pubDate
doesn't seem to be valid. As can be seen belowngx-jira-issue-collector
has apubDate
ofTue, 02 Jun 2020 08:37:26 GMT
nestled between the 7th May 2021 dates, and other occurrences can be seen.This presents an issue when applying the
findOverlap
logic for the lossy logging, as this relies on using the oldest pkg of any given polling set as a marker for triggering the event.npm rss snapshot
```