Closed rajbos closed 1 year ago
I forgot to include the .vscode/
in the gitignore 🤦
I will prefer to ignore non-project related settings because it can be tricky at long term and not all the mainters/users will follow the same approach. For example I use a cool plugin to color out each VS Code instance based in the my preferences but is very different than other colleagues but I don't include it in to the project as it can be annoying for others. Also it will create some additional issues/PRs to maintain it over the time
With the changes in #50 you can keep the files working in local 👍
Hmm, the user settings are in a different json file (settings.json). My PR was to add at least a configuration so that new contributors have an easier way to run the action locally, so they can debug. I can even imagine adding recommended extensions to the extensions.json
file, but that would be it. We could level up the reading of the input variables, so that those are stored in an .env
file, then there would be no user specific configuration in the launch.json
Makes local testing a bit easier 🤗 .