ossf / scorecard

OpenSSF Scorecard - Security health metrics for Open Source
https://scorecard.dev
Apache License 2.0
4.39k stars 482 forks source link

Release: Versioning statement #2624

Open raghavkaul opened 1 year ago

raghavkaul commented 1 year ago

Is your feature request related to a problem? Please describe. Scorecard should issue a versioning statement.

Alternatives

Proposal 1: CalVer

Proposal 2: SemVer

Scorecard API

With either versioning scheme, the Scorecard API should include in results:

Scorecard-Action

Scorecard-Action should use the latest stable version of Scorecard.

naveensrinivasan commented 1 year ago

I completely agree that we need to come to an agreement on the versioning so that other projects are able to depend on and utilize scorecard as a library.

I support using SemVer, as other Projects are increasingly relying on our code base. Here are a few examples which are becoming essential.

  1. https://github.com/guacsec/guac/issues/249
  2. https://github.com/ossf/scorecard/issues/1683#issuecomment-1053626566

I would like to know what are issues/concerns in us maintaining sernver , if any.

spencerschrock commented 1 year ago

I think Go has standardized on SemVer, so at the end of the day it's whether we want that version to be:

Personally, I prefer the former.

Update the docs to issue a SemVer statemeng E.g.: Any update to scoring triggers a major version release, any update to scoring that fixes a bug but doesn't change the algorithm triggers a minor version release.

I think this discussion gets easier with Structured results.

Major: Removal of a rule Minor: Addition of a rule Patch: Bug fix of a rule

There's still the discussion about whether a major scoring change (e.g. rule overhaul) is a Major or a Minor. Which I think can be done with the addition of a new rule for the new behavior, deprecation of the old rule, and then a removal at some point.

Would need to think about feature-flagging scoring changes by release (this is only partially implemented:

I was under the impression we were consolidating on just SCORECARD_EXPERIMENTAL to feature-flag.

API

With either versioning scheme, the Scorecard API should include in results:

Commit SHA of Scorecard Version, if available

This sounds like no change from the current behavior

Action

Scorecard-Action should use the latest stable version of Scorecard.

Again, no change from the current behavior

github-actions[bot] commented 12 months ago

Stale issue message - this issue will be closed in 7 days

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 60 days with no activity.