ossf / scorecard

OpenSSF Scorecard - Security health metrics for Open Source
https://scorecard.dev
Apache License 2.0
4.63k stars 504 forks source link

:seedling: avoid assumptions about versions in tests #4134

Closed raboof closed 6 months ago

raboof commented 6 months ago

What kind of change does this PR introduce?

It makes the tests more resilient against differences in the environment in which scorecard is built.

What is the current behavior?

Tests assume they are ran in an environment where the application version is not known/set.

What is the new behavior (if this is a feature change)?**

Tests make no assumptions about version fields anymore

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to the release-note

(In particular, describe what changes users might need to make in their application as a result of this pull request.)

NONE
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.05%. Comparing base (6815161) to head (fd89e2e). Report is 15 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4134 +/- ## ========================================== - Coverage 66.06% 60.05% -6.02% ========================================== Files 226 214 -12 Lines 16291 15527 -764 ========================================== - Hits 10763 9325 -1438 - Misses 4854 5511 +657 - Partials 674 691 +17 ```