:bug: fix Unlicense detection

spencerschrock commented 3 weeks ago

What kind of change does this PR introduce?

bug fix

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

The code previously had some special logic for handling the Unlicense SPDX identifier and the logic existed in 2 places. While this worked for local file detection, it broke detection for SPDX identifiers provided by the forge.

What is the new behavior (if this is a feature change)?**

This change moves the logic to the single part of the code concerned with figuring out local file SPDX ids, so both work now.

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4144

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to the release-note

(In particular, describe what changes users might need to make in their application as a result of this pull request.)

NONE

spencerschrock commented 3 weeks ago

/scdiff generate License

github-actions[bot] commented 3 weeks ago

Here's a link to the scdiff run

ossf / scorecard