search

ossgang / ossgang-commons

Apache License 2.0
4 stars 0 forks source link

AbstractConnectorObservableValue fix #34

Closed andreacalia closed 4 years ago

andreacalia commented 4 years ago

While connecting to a ConnectorObservableValue there is a small time window in which we unsubscribe from upstream and this causes the force-unsubscribe of all the subscribers

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will decrease coverage by 0.07%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #34      +/-   ##
===========================================
- Coverage     67.87%   67.8%   -0.08%     
  Complexity      178     178              
===========================================
  Files            32      32              
  Lines           551     556       +5     
  Branches         46      47       +1     
===========================================
+ Hits            374     377       +3     
- Misses          157     159       +2     
  Partials         20      20
Impacted Files Coverage Δ Complexity Δ
...s/connectors/AbstractConnectorObservableValue.java 83.33% <50%> (-3.77%) 8 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e34de9b...700c576. Read the comment docs.