search

ossgang / ossgang-commons

Apache License 2.0
4 stars 0 forks source link

Gradle 7 (CBNG 4) compatibility #71

Closed andreacalia closed 1 year ago

andreacalia commented 1 year ago

@michi42 this tries to align the Gradle scripts to Gradle 7 version used inside CERN.

@kaifox I think you would appreciate the (more or less) alignment with latest version ! But in any case can you give the green light ?

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.34% // Head: 74.42% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (56ba3e0) compared to base (6aa1dd0). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #71 +/- ## ============================================ + Coverage 74.34% 74.42% +0.08% - Complexity 407 408 +1 ============================================ Files 55 55 Lines 1181 1181 Branches 80 80 ============================================ + Hits 878 879 +1 Misses 262 262 + Partials 41 40 -1 ``` | [Impacted Files](https://codecov.io/gh/ossgang/ossgang-commons/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...gang/commons/observables/testing/TestObserver.java](https://codecov.io/gh/ossgang/ossgang-commons/pull/71/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21haW4vamF2YS9vcmcvb3NzZ2FuZy9jb21tb25zL29ic2VydmFibGVzL3Rlc3RpbmcvVGVzdE9ic2VydmVyLmphdmE=) | `88.88% <0.00%> (+1.58%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

michi42 commented 1 year ago

Thanks, looks good to me!

In parallel I'm also trying to build our CERN projects with CBNG 4 ;-)

kaifox commented 1 year ago

Hi all,

thanks a lot for updating. Honestly, I cannot see any disadvantage in moving to the lates version ;-) please go ahead and merge!

andreacalia commented 1 year ago

@michi42 @kaifox thanks ! Let's merge it now