search

ossia / libossia

A modern C++, cross-environment distributed object model for creative coding and interaction scoring
https://ossia.io
GNU Lesser General Public License v3.0
206 stars 33 forks source link

[ossia-pd] ø.client add connect with device name #106

Closed avilleret closed 7 years ago

avilleret commented 7 years ago

and a get message to list available devices on the network

bltzr commented 7 years ago

ossia.client: no method for 'get'

bltzr commented 7 years ago

OK, so that's [find_devices( instead of [get(

bltzr commented 7 years ago

maybe there's a potential confusion coming from the fact that connect can be followed indifferently from a protocol or a device name Is that OK ? if it is, it should be documented in the console when pressing [connect( If it's not, then we should find some syntactic differentiation...

avilleret commented 7 years ago

actually default port and IP was initially to quickly test and setup ossia-pd I know this is confusing that connect message could be followed by either a device name or a protocol name and since Minuit protocol seems to be deprecated, I suggest to remove the [connect ( message and just use [connect( message to connect to ws://127.0.0.1:5678

and we keep the [connect ( message to connect given protocol with given settings and the [connect ( message to connect to the device called

bltzr commented 7 years ago

I'm not sure it's a good idea to remove the mention of the protocol: 1/ because even if we don't use Minuit so much with ossia-* apps, maybe someone wants to connect to an old Minuit app (I do this on a daily basis in i-score...) 2/ maybe we'll add support for other protocols in ossia-pd, such as DMX, OSC or others...

though, we can also assume that users shouldn't name their devices the same way as an existing (or future) protocol...

since it's currently working this way, let's keep things as they are, and see if we encounter problems in the future

in any case, I find it good to keep [connect( as a way to get info into the Console, as this is the case for many other functions...

avilleret commented 7 years ago

I didn't suggest to remote the protocol specification when connecting I was just suggesting removing the 2 shortcuts [connect oscquery( and [connect Minuit( and keep [connect( to connect with oscquery on default port but yes in this case, we loose the possibility to print some useful info in the console but there is an help patch right ? Btw, let me know what you think and if I have to change something