search

ossia / libossia

A modern C++, cross-environment distributed object model for creative coding and interaction scoring
https://ossia.io
GNU Lesser General Public License v3.0
206 stars 33 forks source link

network discovery / announce seems broken #723

Closed matcham closed 3 years ago

matcham commented 3 years ago

open ossia.device.maxhelp expose osquery open Score : the device is not visible in device explorer (oscquery)

expose osc seems to work fine.

avilleret commented 3 years ago

I can't reproduce inside Max itself : open ossia.device.maxhelp, "Network exposure" tab click "expose oscquery" then "load distant_client", in the opening patcher click "connect oscquery" -> all sliders / rotpot are updated

but it might be some issue with network service discovery (Bonjour/avahi) on Score side, to check that, could you enter manually ip/port on score and check if it works ?

matcham commented 3 years ago

you're right : entering ip/port manually in score works. But I guess there's something wrong on ossia-max side : with same version of Score (latest release) , if I revert to ossia-max 1.2.4 : it works as expected.

avilleret commented 3 years ago

this is a regression, network service discovery seems to be broken on windows since 1.2.4 (might affect both score and ossia-max)

avilleret commented 3 years ago

@jcelerier do you have any idea on what happen here ?

jcelerier commented 3 years ago

arf no idea, will look into it

avilleret commented 3 years ago

afaict it works fine on Mac OS with Score 3.0.0-a30, Max "Version 8.1.10 (f1acba9) (64-bit mac)" and ossia-max 36e2923d

The same on a Windows VM doesn't work. score was quite unresponsive on my VM but I don't think that might be related though. But then the ossie only affects Windows

avilleret commented 3 years ago

inside Max itself under WIndows, the discovery seems to work (open ossia.device, expose oscquery, open distant_client, connect oscquery) so the issue might be either on Score side or in between, maybe a firewall issue that blocks discovery between 2 softwares. (I did allow both soft to access my private network when Windows defender asked me)

matcham commented 3 years ago

I don't think it's a firewall issue, as I said, if I roll back to ossia-max 1.2.4 it works fine with same Score version, same Max, same everything.

avilleret commented 3 years ago

hum... the main diff between the 2 versions of ossia-max involved here, is that 1.2.4 is built on appveyor while latest-ci-build runs on Azure Devops, so I suspect a configuration issue on Azure side rather than a regression in the code.

avilleret commented 3 years ago

btw I can't make it works on my VM with ossia-max 1.2.4

jcelerier commented 3 years ago

inside Max itself under WIndows, the discovery seems to work (open ossia.device, expose oscquery, open distant_client, connect oscquery) so the issue might be either on Score side or in between, maybe a firewall issue that blocks discovery between 2 softwares. (I did allow both soft to access my private network when Windows defender asked me)

I checked with a Bonjour browser and with latest ossia max master build it does not show up

avilleret commented 3 years ago

I did the same with ossia-max 1.2.4 and it doesn't show up either, does it on your side ?

My bad 1.2.4 does work on my windows VM

jcelerier commented 3 years ago

can you try that one ? with it, bonjour discovery seems to work fine on win32 between max and score ossia-max.zip

avilleret commented 3 years ago

ping @matcham

matcham commented 3 years ago

seems to be fixed, thanks :-)