search

ossia / libossia

A modern C++, cross-environment distributed object model for creative coding and interaction scoring
https://ossia.io
GNU Lesser General Public License v3.0
204 stars 33 forks source link

use GIT_EXECUTABLE #833

Closed x37v closed 10 months ago

x37v commented 10 months ago

I'm running git 3.27.3 on a mac, initial cmake setup fails for me on master, this resolves that.

jcelerier commented 10 months ago

thanks! I'm curious, doesn't Git::Git work for you? I changed the git calls to this one recently (except the one I missed, thanks for noiticing it) as it gives a much more obvious error when not found in cmake-side

x37v commented 10 months ago

no, Git::Git doesn't work for me, that is why I needed this change to get the build going again.

On Thursday, November 16th, 2023 at 5:00 AM, Jean-Michaël Celerier @.***> wrote:

thanks! I'm curious, doesn't Git::Git work for you? I changed the git calls to this one recently (except the one I missed, thanks for noiticing it) as it gives a much more obvious error when not found in cmake-side

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

x37v commented 10 months ago

searching github, I'm not finding others using Git::Git as the alias for the git executable in the same way..

https://github.com/search?q=%22Git%3A%3AGit%22+language%3Acmake&type=code

jcelerier commented 10 months ago

Okay, I had gotten it from cmake's module, apparently it's here since 3.14 (https://cmake.org/cmake/help/latest/module/FindGit.html) so strange that it did not work for you.. maybe a CMake bug to report. In any case merging, thanks for the patch!