Display mode icons - Githubissues

ossia / score

ossia score, an interactive sequencer for the intermedia arts

https://ossia.io

Other

1.48k stars 103 forks source link

Display mode icons #1056

Open thibaudk opened 4 years ago

thibaudk commented 4 years ago

BLicons

This has been discussed else where but All of them should be addressed at once I think for consistency.

linear/nodal icon is backwards. IMO it should show the nodal option when in linear mode and inversely
"Musical" and "show cable" do not have an alternative icon, I think it would make more sense than changing color, as this is already the behavior when hovering.

jcelerier commented 4 years ago

@aklevy would you like to tackle that one ? or I can look into it if you don't have time

aklevy commented 3 years ago

@thibaudk @jcelerier oops, sorry for the late reply, ok for the first point, but for the second point can you clarify a bit what you think should be done ?

jcelerier commented 3 years ago

for the second I imagine something like :

the semiquavers being strikethrough maybe ?
the cable disappearing in "no cables" mode ?

But I think there should be a bit of discussion before rushing it

aklevy commented 3 years ago

hmm, ok we will see for the second one. Meanwhile, the first issue is done.

thibaudk commented 3 years ago

* the semiquavers being strikethrough maybe ?
Could it be something as simple as the "≈" symbol ?
* the cable disappearing in "no cables" mode ?
yes, like the same icon but with a doted line.

hmm, ok we will see for the second one. Meanwhile, the first issue is done. :+1:

jcelerier commented 3 years ago

resolution: disable hovering when the button is selected, onyl enable it when it is not

HugoGenillier commented 3 months ago

modes-ezgif com-video-to-gif-converter In fact having the same behavior for each mode switch will be more consistent. Is the idea of having alternative icons for wireless mode and musical mode still on track ? With that and by deleting the color change on click, they will behave like the temporal/nodal mode icon which will improve the coherence for users.

Also, the inspector displays the same message for each icons when hovered :

temporal/nodal : "Change between nodal and timeline mode"
default/musical : "Enable musical mode"
cable/cableless : "Show cables (Alt+Shift+G)"

Maybe having a different inspector's description for each icon will help the understanding of each mode for users. Like one text for temporal, one for nodal, one for musical etc...

Perhaps I can find the right alternative icons, the doted line seems like a great start.

jcelerier commented 3 months ago

whaddya think @thibaudk @aklevy ?

thibaudk commented 3 months ago

Yes, I still think all 3 should toggle between 2 different icons.