search

ossia / score

ossia score, an interactive sequencer for the intermedia arts
https://ossia.io
Other
1.45k stars 101 forks source link

Build error on Fedora 38 #1512

Closed ycollet closed 2 months ago

ycollet commented 2 months ago

I am trying to build score on Fedora 38 and I met a build error:

/builddir/build/BUILD/ossia-score-3.1.14/src/plugins/score-plugin-protocols/Protocols/DNSSDDeviceEnumerator.cpp: In member function 'void Protocols::DNSSDEnumerator::start()':
/builddir/build/BUILD/ossia-score-3.1.14/src/plugins/score-plugin-protocols/Protocols/DNSSDDeviceEnumerator.cpp:29:11: error: incomplete type 'QTimer' used in nested name specifier
   29 |   QTimer::singleShot(1, this, [this] {
      |           ^~~~~~~~~~
jcelerier commented 2 months ago

oops, likely just missing <QTimer>. I wonder why it builds in CI...

jcelerier commented 2 months ago

(btw if you aren't doing so I really recommend to set -DCMAKE_UNITY_BUILD=1 for package builds, it will make the build much faster with no drawbacks)

ycollet commented 2 months ago

Yes, probably :)

ycollet commented 2 months ago

I will check for UNITY_BUILD flag. Thanks for the hint.

jcelerier commented 2 months ago

pushed the missing header in any case

ycollet commented 2 months ago

Build went fine with -DCMAKE_UNITY_BUILD=1 I close the ticket :) Thanks a lot !

jcelerier commented 2 months ago

fyi : I'm test-driving Fedora as a main OS (through Asahi Linux) so there may be less breakage in the future :)

ycollet commented 2 months ago

Perfect ! :) Thanks a lot for. your software !