ossia / score

ossia score, an interactive sequencer for the intermedia arts
https://ossia.io
Other
1.45k stars 101 forks source link

LFO Process frequency values are different in the inspector and in the widget. #1521

Open guillaumeriousat opened 1 month ago

guillaumeriousat commented 1 month ago

The LFO process frequency values are in hertz (I empirically verified) in the widget and in some kind of strange scaling in the inspector.

I think they should be in hertz everywhere.

image

jcelerier commented 1 month ago

So for this issue I'd like to redo the LFO process in avendish as this grants better flexibility than the previous API this was implemented with.

I had started here : https://github.com/celtera/avendish/blob/3028a955d3489795848c389e8360ea0631b35989/examples/Advanced/Utilities/LFO.hpp#L12

The current code is there : https://github.com/ossia/score/blob/a96d6301131372e592b7b3ea295d1df675c2a49c/src/plugins/score-plugin-fx/Fx/LFO.hpp#L229

@guillaumeriousat would you be interested in looking into this ?

guillaumeriousat commented 1 month ago

Looking into this could be fun. How much do we need to care about compatibility with older patches ?

jcelerier commented 1 month ago

so the compatibility mechanism currently is :