ossia / score

ossia score, an interactive sequencer for the intermedia arts
https://ossia.io
Other
1.5k stars 104 forks source link

minor bugs with "Sound_file" process #724

Closed thibaudk closed 3 years ago

thibaudk commented 6 years ago

It's mostly a GUI issue, appart from the the crash when encapsulating a Sound file. Encapsulation works no problem when the sound file is empty (no file path provided).

"Put in a loop" works in both cases perfectly.

The Gui problem is illustrated here: the representation of the file is desynchronized with the audio output, lagging behind the sound.

vokoscreen-2018-04-06_21-13-14

It gets more and more obvious as time goes by.

Also, loading a sound_file of 4 tracks and above shows weird slashes and parasite in the image (only a cosmetic problem). The 4 tracks plays fine tho.

I apparently cross the limit attempting to play a 20 track file. No output is generated. I'll make Further test to spot the cut off.

Tested on Ubuntu 17.10 commit d32a42439fa1a3c09a3ea52b42c5000ee5647b49

thibaudk commented 6 years ago

At this point, both the crash when encapsulating and the apparent limit of the number of channels for the sound file have been completely fixed, Congrats! Only remains the desynchronized audio and visual representation of the sound file as well as the graphical artefact's when loading a track with more than two channels.

Another bug occurred, regarding sound in general, as well as the "local" Device. Manipulating the speed of the parent interval creates a lot of sound artefact's for a sound file aswell as for the "Audio Generator" process.

This seems to be weirdly correlated to the fact that the "Playtime" parameter in the local device is only refreshed when "speed" is manipulated. (i might be well off there)

vokoscreen-2018-04-10_19-16-03

Settings : _Audio : Driver "JACK" Rate "48000" Buffersize "512" _Execution : all default except Clock Source "Dataflow" Using the "default" Clock Source dosen't cause the problem showed above (but no sound). (this probably belongs to an issue of it's own)

Is there a Setting i am missing? is there a way to differentiate between "true" time-stretch of a sound file, with "natural" pitch shift, and a time-stretch that attempts to preserve the pitch?

Tested on Ubuntu 17.10 commit 84d9adc6947f59b95b996d83dea4765056a4fc08

jcelerier commented 6 years ago

Another bug occurred, regarding sound in general, as well as the "local" Device. Manipulating the speed of the parent interval creates a lot of sound artefact's for a sound file aswell as for the "Audio Generator" process.

it's normal, time stretching / pitch shift is not implemented yet for audio. Basically don't use speed on boxes with audio for now (it'll come in some months, I promise!).

thibaudk commented 6 years ago

ok ok, sorry, no rush!

I'll keep an eye on the 'playtime' of the 'local' device but will reference it in another issue if it is relevant.

jcelerier commented 5 years ago

The Gui problem is illustrated here: the representation of the file is desynchronized with the audio output, lagging behind the sound.

could you try this again on the latest commit ? I think that I found and fixed the cause. There are still weird flashes when there are many waveforms though, I don't know why that is...

jcelerier commented 5 years ago

hidpi

e.g. here's a render of the same waveform at 1'10" mark - seems pretty similar for both Audacity and score

thibaudk commented 5 years ago

It seems to work perfectly now when score is running at 44100 Hz. And with both 44100 and 48kHz files (pitched up).

I Used Jack as a driver. Neither soundfile rates produces good images when score is running at 48kHz.

The fix only works at 44100Hz

jcelerier commented 5 years ago

should be done as of 2.3

thibaudk commented 5 years ago

Sound files appears to be stretched by a factor of 2. They play fine but look displaced.

here is the original in ocean audio with a peak at 7...

Capture d'écran 2019-07-04 16 47 40

and here is the same file in score, with the same peak showing at 14...

imageSon

switching from 48000 to 44100 pushes the peack to appear at 15 ...

THIS IS ONLY A PROBLEM FOR STEREO FILES MONO FILES ARE SHOWING UP CORRECTLY.

jcelerier commented 4 years ago

what does it give now ?

thibaudk commented 3 years ago

Seems to be working now