search

ossimlabs / ossim

Core OSSIM (Open Source Software Image Map) package including C++ code for OSSIM library, command-line applications, tests, and build system
MIT License
300 stars 142 forks source link

Embedded copy of libjsoncpp #115

Closed sebastic closed 7 years ago

sebastic commented 7 years ago

Please remove the libjsoncpp embedded copy and/or support using the system provided libjsoncpp library.

rkanavath commented 7 years ago

can we agree on removing this and adding a find_package() for libjsoncpp ?

sebastic commented 7 years ago

That should be sufficient, if there are no customizations to the embedded copy.

gpotts commented 7 years ago

I would make a modification to check the system and if not present then build the internal? Make the internal conditional?

rkanavath commented 7 years ago

the internal code is using an amalgamated source. can you tell what apps depend on jsoncpp. I see util/ossimShoreLineUtil.cpp. maybe we can disable them just like hdf. the thing it adds additional dependency to projects that follow ossim.

gpotts commented 7 years ago

Gotcha. I didn't put that one in. I need to ask the person that did it and see.

gpotts commented 7 years ago

just sent a message out

rkanavath commented 7 years ago

okay. I will pick on this later when you get a response... ;)

ghost commented 7 years ago

I'm the culprit. Was in hurricane mode here in Florida the last couple of weeks... I'm looking into this today.

ghost commented 7 years ago

The embedded JSONCPP files were removed and cmake files were created/modified to search for and use external system-installed jsoncpp-devel installation.