2.3.2 fails to build with GCC 8

ossimlabs / ossim

Core OSSIM (Open Source Software Image Map) package including C++ code for OSSIM library, command-line applications, tests, and build system

MIT License

296 stars 142 forks source link

2.3.2 fails to build with GCC 8 #200

Closed sebastic closed 6 years ago

sebastic commented 6 years ago

To test if Debian Bug #897829 was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump
cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1
/usr/bin/g++-8  -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG  -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o  -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread 
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<int>(int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned char>(unsigned char, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)'
collect2: error: ld returned 1 exit status
make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1
make[3]: Leaving directory '/build/ossim-2.3.2/debian/build'
make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[ 91%] Linking CXX executable ../../bin/ossim-autreg
cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1
/usr/bin/g++-8  -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG  -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o  -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread 
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<int>(int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned char>(unsigned char, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)'
collect2: error: ld returned 1 exit status
make[3]: *** [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1
make[3]: Leaving directory '/build/ossim-2.3.2/debian/build'
make[2]: *** [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2
[ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom
cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1
/usr/bin/g++-8  -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG  -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o  -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread 
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<int>(int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned char>(unsigned char, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)'
../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)'
collect2: error: ld returned 1 exit status

To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8
export CXX=g++-8

gpotts commented 6 years ago

Hello Bas:

Is this only for pixelflip or is this for any application linking to OSSIM.

Take care

Garrett Potts

On May 28, 2018, at 9:52 AM, Bas Couwenberg notifications@github.com wrote:

To test if Debian Bug #897829 https://bugs.debian.org/897829 was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 91%] Linking CXX executable ../../bin/ossim-autreg cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(double, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(float, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2 [ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8 export CXX=g++-8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB.

gpotts commented 6 years ago

Hello Bas:

Never mind. It is any app linking to the library.

Let me see if I see anything obvious

Take care

Garrett

On May 28, 2018, at 9:52 AM, Bas Couwenberg notifications@github.com wrote:

To test if Debian Bug #897829 https://bugs.debian.org/897829 was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 91%] Linking CXX executable ../../bin/ossim-autreg cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(double, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(float, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2 [ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8 export CXX=g++-8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB.

gpotts commented 6 years ago

Hello Bas:

I think I see the problem. The templae methods were put into the source an not in the headers. Surprised this didn’t have problems before

Let me do a quick fix this morning and I will let you know when you can test.

Take care

Garrett

On May 28, 2018, at 9:52 AM, Bas Couwenberg notifications@github.com wrote:

To test if Debian Bug #897829 https://bugs.debian.org/897829 was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 91%] Linking CXX executable ../../bin/ossim-autreg cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(double, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(float, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2 [ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8 export CXX=g++-8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB.

omarossim commented 6 years ago

Hello:

Actually I am not sure. Might need to look for a few. Seems others do the same thing but seems you are only getting undefined symbols when doing gcc 8 on debian.

Take care

Garrett

On May 29, 2018, at 7:31 AM, gpotts notifications@github.com wrote:

Hello Bas:

I think I see the problem. The templae methods were put into the source an not in the headers. Surprised this didn’t have problems before

Let me do a quick fix this morning and I will let you know when you can test.

Take care

Garrett

On May 28, 2018, at 9:52 AM, Bas Couwenberg notifications@github.com wrote:

To test if Debian Bug #897829 https://bugs.debian.org/897829 was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 91%] Linking CXX executable ../../bin/ossim-autreg cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(double, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(float, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2 [ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8 export CXX=g++-8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200#issuecomment-392744156, or mute the thread https://github.com/notifications/unsubscribe-auth/AGpvyufRnf16pHzOehDDh1iP-7ItIjAkks5t3TF0gaJpZM4UQOnB.

gpotts commented 6 years ago

Hello Bas:

I saw in the BitMAskWriter that it was calling a template method directly. That method should not be called directly. I made the modification but have no way of testing that bitmask writer. Could you test the build on a debian running gcc 8?

Dave, do you have a test for bitmask writer?

Take care

Garrett Potts

On May 29, 2018, at 7:33 AM, omarossim <notifications@github.com mailto:notifications@github.com> wrote:

Hello:

Actually I am not sure. Might need to look for a few. Seems others do the same thing but seems you are only getting undefined symbols when doing gcc 8 on debian.

Take care

Garrett

On May 29, 2018, at 7:31 AM, gpotts <notifications@github.com mailto:notifications@github.com> wrote:

Hello Bas:

I think I see the problem. The templae methods were put into the source an not in the headers. Surprised this didn’t have problems before

Let me do a quick fix this morning and I will let you know when you can test.

Take care

Garrett

On May 28, 2018, at 9:52 AM, Bas Couwenberg <notifications@github.com mailto:notifications@github.com> wrote:

To test if Debian Bug #897829 <https://bugs.debian.org/897829 https://bugs.debian.org/897829> was an actual issue, OSSIM 2.3.2 has been built with GCC 8 and unfortuntely it fails to build:

[ 91%] Linking CXX executable ../../bin/ossim-adrg-dump cd /build/ossim-2.3.2/debian/build/apps/ossim-adrg-dump && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-adrg-dump.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-adrg-dump.dir/ossim-adrg-dump.cpp.o -o ../../bin/ossim-adrg-dump -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<short>(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: *** [apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/build.make:99: bin/ossim-adrg-dump] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: *** [CMakeFiles/Makefile2:303: apps/ossim-adrg-dump/CMakeFiles/ossim-adrg-dump.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 91%] Linking CXX executable ../../bin/ossim-autreg cd /build/ossim-2.3.2/debian/build/apps/ossim-autreg && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-autreg.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-autreg.dir/ossim-autreg.cpp.o -o ../../bin/ossim-autreg -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(double, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned short>(unsigned short, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(float, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<unsigned int>(unsigned int, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status make[3]: [apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/build.make:99: bin/ossim-autreg] Error 1 make[3]: Leaving directory '/build/ossim-2.3.2/debian/build' make[2]: [CMakeFiles/Makefile2:413: apps/ossim-autreg/CMakeFiles/ossim-autreg.dir/all] Error 2 [ 91%] Linking CXX executable ../../bin/ossim-applanix2ogeom cd /build/ossim-2.3.2/debian/build/apps/ossim-applanix2ogeom && /usr/bin/cmake -E cmake_link_script CMakeFiles/ossim-applanix2ogeom.dir/link.txt --verbose=1 /usr/bin/g++-8 -g -O2 -fdebug-prefix-map=/build/ossim-2.3.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-z,relro -Wl,-z,now -rdynamic CMakeFiles/ossim-applanix2ogeom.dir/ossim-applanix2ogeom.cpp.o -o ../../bin/ossim-applanix2ogeom -Wl,-rpath,/build/ossim-2.3.2/debian/build/lib: ../../lib/libossim.so.1.9.0 -lgeos -lgeos_c -lgeotiff -ljpeg -ltiff -ljsoncpp -ldl -ljsoncpp -ldl -lfreetype -lz -lpthread ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<double>(double, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned short, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to void ossimPixelFlipper::flipPixels<float>(float, ossimImageData*, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference tovoid ossimPixelFlipper::flipPixels(unsigned char, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(unsigned int, ossimImageData, unsigned int)' ../../lib/libossim.so.1.9.0: undefined reference to `void ossimPixelFlipper::flipPixels(short, ossimImageData*, unsigned int)' collect2: error: ld returned 1 exit status To reproduce the issue, build OSSIM in a Debian unstable environment with the gcc-8 & g++-8 packages installed, and use these with:

export CC=gcc-8 export CXX=g++-8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/ossimlabs/ossim/issues/200 https://github.com/ossimlabs/ossim/issues/200>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB https://github.com/notifications/unsubscribe-auth/ACL9v_0PMw2239d3C9i4OpxAqoruBJRBks5t3AEEgaJpZM4UQOnB>.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/ossimlabs/ossim/issues/200#issuecomment-392744156 https://github.com/ossimlabs/ossim/issues/200#issuecomment-392744156>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGpvyufRnf16pHzOehDDh1iP-7ItIjAkks5t3TF0gaJpZM4UQOnB https://github.com/notifications/unsubscribe-auth/AGpvyufRnf16pHzOehDDh1iP-7ItIjAkks5t3TF0gaJpZM4UQOnB>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200#issuecomment-392744747, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v8gh3ozV2pGkfkg-QHQGbSK3yJCyks5t3TIHgaJpZM4UQOnB.

sebastic commented 6 years ago

I've included 545b65169484ad0d5237bf5c6d0279558538b62b as a patch in the Debian package, and that fixes the build failure with GCC 8. Thank!

gpotts commented 6 years ago

Hello Bas:

Good deal!!

Thank you for the verification

Take care

Garrett

On May 29, 2018, at 9:50 AM, Bas Couwenberg <notifications@github.com mailto:notifications@github.com> wrote:

I've included 545b651 https://github.com/ossimlabs/ossim/commit/545b65169484ad0d5237bf5c6d0279558538b62b as a patch in the Debian package, and that fixes the build failure with GCC 8. Thank!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/200#issuecomment-392783830, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v-uYvZTspqhCpXZYgfKVFJ5My0UIks5t3VIngaJpZM4UQOnB.