Closed ghansham closed 5 years ago
Hello:
We do not use OpenThreads anymore. We are using the C++11 standards for mutex locking ,…etc.
Take care
Garrett
On Jun 3, 2019, at 8:37 AM, ghansham notifications@github.com wrote:
Hi...
It seems its long since I checked out the ossim branch. Atleast 3.5 years. What I am seeing is the inclusion of in some of the header files in base directory is leading to build failure. I feel we should detect in pre build phase.
And the OpenThreads package finding is removed from CMakeLists.txt somehow. This leads to OpenThreads library and include paths not getting set during pre build phase. Another suggestion regarding jsoncpp is to include an environment variable which could point to location where it is installed if not in standard location. Something like it is done in FindGEOS.cmake. Regards Ghansham
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/226?email_source=notifications&email_token=ABVG7SUBXRJO7EXFCAR5YFDPYUGB3A5CNFSM4HSHTZ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXIXGOQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVG7SQZB6VCESVQIKKVRYTPYUGB3ANCNFSM4HSHTZ2Q.
Thanks a lot.
Hi...
It seems its long since I checked out the ossim branch. Atleast 3.5 years. What I am seeing is the inclusion of in some of the header files in base directory is leading to build failure. I feel we should detect in pre build phase.
And the OpenThreads package finding is removed from CMakeLists.txt somehow. This leads to OpenThreads library and include paths not getting set during pre build phase. Another suggestion regarding jsoncpp is to include an environment variable which could point to location where it is installed if not in standard location. Something like it is done in FindGEOS.cmake. Regards Ghansham