ossimlabs / ossim

Core OSSIM (Open Source Software Image Map) package including C++ code for OSSIM library, command-line applications, tests, and build system
MIT License
296 stars 142 forks source link

Reset of existing imageViewTransform to NULL #229

Open ghansham opened 5 years ago

ghansham commented 5 years ago

https://github.com/ossimlabs/ossim/blob/ea69ce56c88bdcc0a3e2d001261f3f6ef949f60b/src/imaging/ossimImageRenderer.cpp#L1914

This line reset the existing imageViewProjectionTransform to NULL value. m_ImageViewTransform should be checked for validity before setting to zero. This breaks backward compatibility.

omarossim commented 5 years ago

Hello:

I am in the middle of stuff right now but will have to look at the code to verify.

Take care

Garrett

On Jun 6, 2019, at 2:20 AM, ghansham notifications@github.com wrote:

https://github.com/ossimlabs/ossim/blob/ea69ce56c88bdcc0a3e2d001261f3f6ef949f60b/src/imaging/ossimImageRenderer.cpp#L1914 https://github.com/ossimlabs/ossim/blob/ea69ce56c88bdcc0a3e2d001261f3f6ef949f60b/src/imaging/ossimImageRenderer.cpp#L1914 This line reset the existing imageViewProjectionTransform to NULL value. m_ImageViewTransform should be checked for validity before setting to zero. This breaks backward compatibility.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/229?email_source=notifications&email_token=ABVG7SRCZHG3NDFSB2SA6XDPZCUEXA5CNFSM4HU3MME2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GX5633Q, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVG7SSHY4INVQ3ZKDCJEOTPZCUEXANCNFSM4HU3MMEQ.