search

ossimlabs / ossim

Core OSSIM (Open Source Software Image Map) package including C++ code for OSSIM library, command-line applications, tests, and build system
MIT License
295 stars 142 forks source link

up is up angle calculation grid #279

Closed kjurka closed 2 years ago

kjurka commented 2 years ago

Only reading through the code, so I haven't actually run this, but it looks like the grid layout for the up is up angle calculation is wrong:

https://github.com/ossimlabs/ossim/blob/82417ad868fac022672335e1684bdd91d662c18c/src/imaging/ossimImageGeometry.cpp#L1538

That top row should have -heightPercent, right?

gpotts commented 2 years ago

Hello Kris:

Yes, you are correct in that assessment. The top row should have -heightPercent so there is a bias now in the average up is up calculation. Did you want to do a pull request?

Thank you for the catch!

Take care

Garrett

On May 5, 2022, at 2:21 PM, Kris Jurka @.***> wrote:

Only reading through the code, so I haven't actually run this, but it looks like the grid layout for the up is up angle calculation is wrong:

https://github.com/ossimlabs/ossim/blob/82417ad868fac022672335e1684bdd91d662c18c/src/imaging/ossimImageGeometry.cpp#L1538 https://github.com/ossimlabs/ossim/blob/82417ad868fac022672335e1684bdd91d662c18c/src/imaging/ossimImageGeometry.cpp#L1538 That top row should have -heightPercent, right?

— Reply to this email directly, view it on GitHub https://github.com/ossimlabs/ossim/issues/279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARP3PY5NWQ5PYFHFRJYMRDVIQGRXANCNFSM5VF4DDFA. You are receiving this because you are subscribed to this thread.