search

osskit / currencies

MIT License
0 stars 0 forks source link

Croatia has Euro from 1.1.2023. #2

Open WardenCommander opened 1 year ago

WardenCommander commented 1 year ago

Hello, i see you have forked: ninternal/currency-codes

And made it it typescript 👍👌

Just info that Croatia has EURO since 1.1.2023., when tou have time please update and waiting for npm deployment.

Also maybe add option for internationalization 🤔

SharonGrossman commented 1 year ago

Hey :) I will add Croatia to the list of countries that use EURO, not sure about removing the Kuna currency yet because it might be of use until it's totally deprecated. (https://github.com/osskit/currencies/pull/3) Also, what do you mean by internationalization? Thanks!

WardenCommander commented 1 year ago

Maybe keep "Kuna" until it's deprecated, but it's not in use anymore. You can only exchange it in the bank. By internationalization, I mean that you can easily translate names and countries. Also, have a look at these packages; they have saved "standard," so you can use the same setup for all of them. just an idea for you if you are interested in adding functions as they have, and we would have language, country, nationality, and currency( your plugin) all in the same format.

"@cospired/i18n-iso-languages": https://www.npmjs.com/package/@cospired/i18n-iso-languages "i18n-iso-countries": https://www.npmjs.com/package/i18n-iso-countries "i18n-nationality": https://www.npmjs.com/package/i18n-nationality