osslate / irc-message

Performant, streaming IRC message parser
BSD 2-Clause "Simplified" License
92 stars 13 forks source link

Add smiley support - because we all need smiles #12

Closed rodms10 closed 10 years ago

rodms10 commented 10 years ago

While implementing an IRC server for ircanywhere I noticed that smiley faces where being butchered. This happens because the code on toString() was only prepending the : when there is a space in the param. One of the colons in a message such as PRIVMSG #smiley-test ::) ended up being dropped, causing clients to render just a sad ).

osslate commented 10 years ago

Thanks! :)

rodms10 commented 10 years ago

Thanks for merging! Any idea when this will be published to npm?

osslate commented 10 years ago

Already published irc-message@2.0.1!

rodms10 commented 10 years ago

Awesome! \o/