search

ossn / fixme_backend

6 stars 17 forks source link

Sorting by GitHubUpdatedAt field #17

Closed himankpathak closed 4 years ago

himankpathak commented 5 years ago

Description of the Change

Added GitHubUpdatedAt field which is fetched from GitHub's GraphQL API "updatedAt". It is stored in database at column GitHubUpdatedAt.

Benefits

Now issues can be sorted using GitHubUpdatedAt field.

Applicable Issues

Closes #5 Closes #7 Closes #12

himankpathak commented 5 years ago

@alexdor should a new issue be opened in the frontend to sort using GitHubUpdatedAt field?

alexdor commented 5 years ago

@alexdor should a new issue be opened in the frontend to sort using GitHubUpdatedAt field?

Yes, once this is merged we should do that : )

alexdor commented 4 years ago

@himankpathak this still has conflicts, could you resolve the conflicts?

himankpathak commented 4 years ago

I think I resolved all the conflicts with git rebase. The PR says "This branch has no conflicts with the base branch". Am I missing something?

alexdor commented 4 years ago

I'm getting this error so I don't think they where solved, you can try creating a new fork and cherry-picking your commits to that one

Screenshot 2019-10-06 at 22 57 20
himankpathak commented 4 years ago

This is weird, on my side I don't know why it's not showing the conflicts.

Screenshot from 2019-10-07 09-39-23

Should I close this PR and make a copy of this branch from commit https://github.com/ossn/fixme_backend/pull/17/commits/cd0f7ef96eaa9efc43ebe527137b34aa25f48b3c and add commit https://github.com/ossn/fixme_backend/pull/17/commits/d6f1492109c6e48f173d36568fe14ff91f59fe36?

alexdor commented 4 years ago

Yeah, try creating a new pr, maybe that will solve the issue. Before you copy the branch, try just closing this pr and opening a new one, maybe it’s a GitHub issue that it shows conflicts

Best, Alex On 7 Oct 2019, 06:16 +0200, Himank Pathak notifications@github.com, wrote:

This is weird, on my side I don't know why it's not showing the conflicts. Should I close this PR and make a copy of this branch from commit cd0f7ef and add commit d6f1492? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.