search

ossn / ossn-frontend

The homepage of Mozilla's Open Source Student Network
https://ossn.club
MIT License
4 stars 11 forks source link

Newly generated profiles are broken #276

Open bacharakis opened 5 years ago

bacharakis commented 5 years ago

I am not sure whether it's backend or front end, but newly created profiles have a broken layout and people can't login with these profiles.

screenshot from 2019-03-06 15-42-02 screenshot from 2019-03-06 15-41-56 screenshot from 2019-03-06 15-40-41

iropal commented 5 years ago

@bacharakis @alexdor I attempted to debug it locally but I faced some issues. I logged in with new account and though the login page redirected me to localhost, the user was not logged in and not added in the backend, so I cannot reproduce the broken layout issue.

alexdor commented 5 years ago

Did you delete your user from the admin app? if so you should be getting an error that you need to contact an administrator (check the url, the frontend doesn't display or check any error)

iropal commented 5 years ago

@alexdor I did delete the user from the admin app and I am getting the error.

alexdor commented 5 years ago

Yeah, that’s because if the user is deleted (which means banned) we have to manually enable him again. Could you try logging in with a different user? On 6 Mar 2019, 17.29 +0100, Iro Palampougiouki notifications@github.com, wrote:

@alexdor I did delete the user from the admin app and I am getting the error. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

iropal commented 5 years ago

I did log in with two new users and cannot reproduce the issue. We had a regression yesterday which had this result on the user page and was fixed with pr #265 and #267. @bacharakis are those print screens from today?

alexdor commented 5 years ago

Even if they are from today, it might be cached version (the service worker helps a lot with the speed of the website but it creates a n+1 cache issue, there are a few good points for the service workers here https://gist.github.com/Rich-Harris/fd6c3c73e6e707e312d7c5d7d0f3b2f9 ) On Wed, 6 Mar 2019 at 17.54, Iro Palampougiouki notifications@github.com wrote:

I did log in with two new users and cannot reproduce the issue. We had a regression yesterday which had this result on the user page and was fixed with pr #265 https://github.com/ossn/ossn-frontend/pull/265 and #267 https://github.com/ossn/ossn-frontend/pull/267. @bacharakis https://github.com/bacharakis are those print screens from today?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ossn/ossn-frontend/issues/276#issuecomment-470186429, or mute the thread https://github.com/notifications/unsubscribe-auth/AICthwEJ8m0D_NrYOXXbQ7MWGkTgbWLcks5vT_LXgaJpZM4bhDOl .

bacharakis commented 5 years ago

I just checked with a clear cache and got this: Screenshot from 2019-03-18 18-25-11

STR: Browser: 67.0a1 (2019-03-01) (64-bit) OS: Linux 4.16.10-300.fc28.x86_64

1) Create a new profile using an email to sign up 2) Open the link to login to the website