ossobv / proxmove

Migrate virtual machines between different Proxmox VE clusters with minimal downtime
261 stars 31 forks source link

Fix efidisk including discard=on #46

Open jclab-joseph opened 1 year ago

wdoekes commented 1 year ago

Thanks for this changeset.

Why is this? Does setting discard on the efidisk not work? How does that manifest itself?

Also, maybe we want (old)slot passed to ProxmoxVolume, so we can inspect it for /efidisk/ there instead of having to pass no_discard around.

jclab-joseph commented 1 year ago
2022-10-05 16:59:28,097: INFO: Begin copy of 'efidisk0' (local-lvm:vm-9010-disk-1,size=4M) to pve-ds01 (vm-20024-disk-0)
2022-10-05 16:59:28,283: INFO: Volume transferring/conversion 100% (is/was) complete!
2022-10-05 16:59:28,300: ERROR: Issue when adding volume to new VM: 'pve-ds01:vm-20024-disk-0,discard=on,size=4M'
Traceback (most recent call last):
  File "/root/proxmove-main/./proxmove", line 1810, in create_volume
    self.api_vm.config.put(**{volume_key: new_properties})
  File "/usr/lib/python3/dist-packages/proxmoxer/core.py", line 90, in put
    return self(args)._request("PUT", data=data)
  File "/usr/lib/python3/dist-packages/proxmoxer/core.py", line 78, in _request
    raise ResourceException("{0} {1}: {2}".format(resp.status_code, httplib.responses[resp.status_code],
proxmoxer.core.ResourceException: 400 Bad Request: b'{"errors":{"efidisk0":"invalid format - format error\\nefidisk0.discard: property is not defined in schema and the schema does not allow additional properties\\n"},"data":null}'
Traceback (most recent call last):