Closed wdoekes closed 1 day ago
Check https://github.com/ossobv/sonic-buildimage/blob/master/src/sonic-device-data/Makefile
Which fetches data from https://github.com/ossobv/sonic-buildimage/blob/master/devices but not sure how yet.
Looks like the files indeed are not there, but only in proprietary land somewhere?
On the proprietary install we have this nice package:
# apt-cache show sonic-device-data
Package: sonic-device-data
Status: install ok installed
Priority: optional
Section: misc
Installed-Size: 75166
Maintainer: Joe LeVeque <jolevequ@microsoft.com>
Architecture: all
Version: 1.0-1
Description: Device-specific data files for SONiC
Description-md5: 71ac212b4d6f181dec14ec448f20f4b4
versus this bigger(!) one
# apt-cache show sonic-device-data
Package: sonic-device-data
Status: install ok installed
Priority: optional
Section: misc
Installed-Size: 139926
Maintainer: Joe LeVeque <jolevequ@microsoft.com>
Architecture: all
Version: 1.0-1
Description: Device-specific data files for SONiC
Description-md5: 71ac212b4d6f181dec14ec448f20f4b4
Also interesting to note that there are actually asic-specific packages:
root@leaf1:~# dpkg -l | grep sonic-platform
ii sonic-platform-accton-as7326-56x 1.1 amd64 kernel modules for platform devices such as fan, led, sfp
ii sonic-platform-pddf 1.1 amd64 kernel modules for platform devices such as psu, fan, sfp, led
root@spine1:~# dpkg -l | grep sonic-platf
ii sonic-platform-accton-as9716-32d 1.1 amd64 kernel modules for platform devices such as fan, led, sfp
ii sonic-platform-pddf 1.1 amd64 kernel modules for platform devices such as psu, fan, sfp, led
These were found auto-installed on the respective leaf/spine where they belong.
It looks buggy that both packages do contain some other files.
root@leaf1:~# dpkg-deb -c /host/image-202405-osso.0-dirty-20241102.171738/platform/common/sonic-platform-accton-as9716-32d_1.1_amd64.deb | grep 7326
drwxr-xr-x root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/
-rw-r--r-- root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/__init__.py
drwxr-xr-x root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/__pycache__/
-rw-r--r-- root/root 162 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/__pycache__/__init__.cpython-311.pyc
-rw-r--r-- root/root 9111 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/__pycache__/fanutil.cpython-311.pyc
-rw-r--r-- root/root 8135 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/__pycache__/thermalutil.cpython-311.pyc
-rw-r--r-- root/root 8835 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/fanutil.py
-rw-r--r-- root/root 6272 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as7326_56x/thermalutil.py
Also in the other image:
root@leaf1:~# dpkg-deb -c /host/image-4.4.0-Enterprise_Base/platform/x86_64-accton_as7326_56x-r0/sonic-platform-accton-as7326-56x_1.1_amd64.deb | grep 9716
drwxr-xr-x root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/
-rw-r--r-- root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/__init__.py
drwxr-xr-x root/root 0 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/__pycache__/
-rw-r--r-- root/root 144 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/__pycache__/__init__.cpython-39.pyc
-rw-r--r-- root/root 5469 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/__pycache__/fanutil.cpython-39.pyc
-rw-r--r-- root/root 2701 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/__pycache__/thermalutil.cpython-39.pyc
-rw-r--r-- root/root 7528 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/fanutil.py
-rw-r--r-- root/root 3748 2017-12-19 01:35 ./usr/lib/python3/dist-packages/as9716_32d/thermalutil.py
Not in the Edgecore though:
root@spine1:~# dpkg-deb -c /host/image-Edgecore-SONiC_20240425_054819_ec202111_819/platform/x86_64-accton_as7326_56x-r0/sonic-platform-accton-as7326-56x_1.1_amd64.deb | grep 9716
(empty)
Looks like things work.
We won't be touching these unless we have to.
In
SONiC-OS-Edgecore-SONiC_20240425_054819_ec202111_819
there are these files:And these files:
In the
SONiC-OS-202405-osso.0-dirty-20241102.171738
image, they were not present.This causes
/usr/bin/pcie-check.sh
to bail out without doing anything useful.Copying the files from
SONiC-OS-Edgecore-SONiC_20240425_054819_ec202111_819
helps. But we need to investigate why they are missing. They were both supposedly mostly 2017-02 something, so it's not that my build/branch was too old.