ossrs / httpx-static

A HTTP/HTTPS API proxy for SRS.
https://github.com/ossrs/srs
MIT License
641 stars 221 forks source link

Restructure imports via goimports #60

Closed mbeacom closed 7 years ago

winlinvip commented 8 years ago

Did you use some cmd tool to format the code? And what's the cmd?

mbeacom commented 8 years ago

I'm using Atom as my editor with goimports and gofmt which are leveraged by the Go-imports Atom package

go get -v golang.org/x/tools/cmd/goimports

winlinvip commented 8 years ago

I got it. I know gofmt, but not goimports yet, I will study it then merge your pr, thanks.

mbeacom commented 8 years ago

Any time to look at goimports yet? @winlinvip

winlinvip commented 8 years ago

I don't think it's very important to use goimports or just gofmt, because I need to refine the basic structure for oryx to make the infrastructure more strong. But I am not sure about the arch of oryx and lack of time, so please hold on, don't close this PR for it's useful(only not hurry to merge it).

mbeacom commented 8 years ago

@winlinvip Thank you! That sounds good to me. If you need anything, let me know. I'd really like to contribute where and when possible!

winlinvip commented 7 years ago

@mbeacom Please help to review the introduction of oryx, I have known the new arch of oryx. https://github.com/ossrs/go-oryx#go-oryx

mbeacom commented 7 years ago

@winlinvip I sent you a Skype message with some questions and some changes to the readme. Let me know if you need anything else! I'll close this for now.

winlinvip commented 7 years ago

@mbeacom 👌