search

osstotalsoft / rocket-ui-ts

A collection of reusable and composable React components written in TypeScript built on top of Material UI Core V5
MIT License
19 stars 4 forks source link

useToast autoClose option defaults to not close the toast and the tooltip documentation does not reflect this #124

Closed cristidumitrescutotalsoft closed 2 months ago

cristidumitrescutotalsoft commented 3 months ago

Latest version

Description

As the component works, the toast notification does not close. This can be an issue when switching from the react-toastify component to the Rocket-UI component. For this feature request, the autoClose option for the useToast component may be given the default value.

Examples

For the code: showToast(t("PersonWorkplaces.Updated"), "success"); image That remains on the screen

Desired effect

The code shall have a default value for autoClose that closes the toast window

cristidumitrescutotalsoft commented 2 months ago

Examples

The problem was actually in the tooltip documentation. It did not reflect the actual default value. As shown below. image

Desired effect

The code shall have a default value for autoClose of false and for that to be represented in the documentation.

DCosti commented 2 months ago

fixed in https://github.com/osstotalsoft/rocket-ui-ts/pull/125