search

osstotalsoft / rocket-ui-ts

A collection of reusable and composable React components written in TypeScript built on top of Material UI Core V5
MIT License
19 stars 4 forks source link

Add ListFilter component #39

Closed Boerescu-Razvan closed 1 year ago

Boerescu-Razvan commented 1 year ago

Port ListFilter component to typescript

alexandra-c commented 1 year ago

Increase the number of tests to cover at least 80% code coverage. image

alexandra-c commented 1 year ago

ListFilter and UserPreferencesPopup files are huge, they probably have low rendering performance. You need to split them in smaller components to reduce the quantity of UI components that will re-render when something changes. In addition, the code is hard to read and debug being so big.

alexandra-c commented 1 year ago

Do not import icons from material-ui directly from the index file. Use specific imports. material-ui does not have tree-shaking so it will include all the icons in our bundle.

Spcific imports:

import Close from '@mui/icons-material/Close'