ossuminc / riddl

A compiler for the DDD-based design language RIDDL
https://riddl.tech/
Apache License 2.0
23 stars 6 forks source link

[FEATURE] Add Timing Data to Parsing Results #664

Closed AlexWeinstein92 closed 14 hours ago

AlexWeinstein92 commented 2 months ago

Is your feature already requested in another issue?

No

Is your feature a defect?

No

Is your feature request related to a problem? Please describe.

How to display timing results to users in the IDEA plugin

Describe the solution you'd like

Timing results should be either packed into PassesResult or else returned along with it as a tuple or other structure

reid-spencer commented 2 months ago

How to display timing results to users in the IDEA plugin

I think the correct way to show timing data is the same way it is done in riddlc: in the logged output. That is the IDEA plugin's textual output log should contain the timing data exactly the way riddlc would have logged it. Thus, it isn't necessary to change 100 apis to include timing data.

reid-spencer commented 1 month ago

@AlexWeinstein92 - Do you concur with the above analysis? Just use the Logger? If so, please close this Issue.

reid-spencer commented 14 hours ago

Insufficient responses. Closing this in favor of only putting out timing in the Logger.