search

ossuminc / riddl

A compiler for the DDD-based design language RIDDL
https://riddl.tech/
Apache License 2.0
23 stars 6 forks source link

[DEFECT] CommonOptions not available when formatting outside a PC #697

Open AlexWeinstein92 opened 6 days ago

AlexWeinstein92 commented 6 days ago

Symptom

After each run, the plugin saves the Messages that come back from runCommandWithArgs These messages do not respect the check for commonOptions.noANSIMessages because the options are not passed into the format function or its downstream annotateErrorLine function

Expected Behavior

NoANSIMessages, and all other CommonOptions, should appropriately affect Messages.format even outside of a PlatformContext

Steps To Reproduce

List the steps to reproduce the symptomatic behavior:

  1. Inspect the output Messages of runcommandWithArgs and note that ANSI formatting codes are still present even when noANSIMessages = true
reid-spencer commented 6 days ago

This should have been fixed in this commit:

https://github.com/ossuminc/riddl/commit/302091ea0c75dc43670dbdbd49b91f54dab8dc5f