search

ostafen / clover

A lightweight document-oriented NoSQL database written in pure Golang.
MIT License
680 stars 55 forks source link

added in-memory storage engine #24

Closed segfault99 closed 2 years ago

ostafen commented 2 years ago

Sorry for the double review. I mistakenly clicked the confirm button

ostafen commented 2 years ago

Thank you for your quick fixes! One last thing, before merging: instead of calling e.Lock()/Unlock() every time you use the replaceDocs() function, you could move the statements directly inside the body of the replaceDocs() method.

ostafen commented 2 years ago

Thank you very much, I appreciated your work :=) If you want to look for further contributions in the future, you are welcome I'll work on the integration in order to merge your changes in the merge branch soon

jsgm commented 2 years ago

This looks really good! Congrats all for the work