search

ostafen / clover

A lightweight document-oriented NoSQL database written in pure Golang.
MIT License
680 stars 55 forks source link

Added ImportCollection and ExportCollection #31

Closed jsgm closed 2 years ago

ostafen commented 2 years ago

@jsgm, Did you finish your revision? I see some unresolved points yet

jsgm commented 2 years ago

@jsgm, Did you finish your revision? I see some unresolved points yet

Haven't finished yet, will update all points later today

ostafen commented 2 years ago

Ok, request me a review when you're done :=)

ostafen commented 2 years ago

Is this ready for review?

jsgm commented 2 years ago

Feel free to check

jsgm commented 2 years ago

Already changed the code to match the proposals made in the code review.

Removed the tests for now from this PR to keep it clearer, will do them in a separate branch: feature/json-tests for example

ostafen commented 2 years ago

@jsgm, tests ensure that a feature has been correctly implemented, so it doesn't make sense to close a PR without the corresponding tests for a given functionality. Take your time, but include tests in this PR, please :=)

ostafen commented 2 years ago

@jsgm, any update on this? Since I would like to release the v1.1.0 by the end this month, I can give an help if you are too busy with this

jsgm commented 2 years ago

@jsgm, any update on this? Since I would like to release the v1.1.0 by the end this month, I can give an help if you are too busy with this

Hey @ostafen ! Sure, any help will be appreciated