search

ostap / comp

a tool for querying files in various formats
MIT License
43 stars 2 forks source link

supporting XML input files #16

Closed julochrobak closed 11 years ago

julochrobak commented 11 years ago

implemented according to the discussion in the #12

ostap commented 11 years ago

Good to see the XML support, especially in such a flexible way. I am done with the review and happy to merge it if you squash the changes and apply the remaining comments.

julochrobak commented 11 years ago

I'm ready to squash the changes, just see my last comment on the way how Store is initialized and let me know. I believe we'll the discussion if I squash the changes on this branch, so I'll create a new pull request from a new clean branch.

ostap commented 11 years ago

All merged.