Mixed up formulas in the environmental correction ratio

ostaquet / Arduino-MQ131-driver

Arduino driver for gas sensor MQ131 (Ozone / O3)

MIT License

64 stars 19 forks source link

Mixed up formulas in the environmental correction ratio #41

Closed JosephJohnZ closed 3 years ago

JosephJohnZ commented 3 years ago

Hello, while going through your code I noticed that the equations for 30% an 85% curves seem to be switched places.

ostaquet commented 3 years ago

Hi @JosephJohnZ, Can you elaborate a bit? Are you talking about environmental impact on the O3 level?

JosephJohnZ commented 3 years ago

Yes, I mean the formulas in getEnvCorrectRatio method, I checked with the excell file you provided and according to the graph there it seems that the formulas "For humidity > 75%, use the 85% curve" and "Humidity < 50%, use the 30% curve" in the .cpp file are switched. Unless I saw it wrong

ostaquet commented 3 years ago

You're right!

Just fixed in release 1.5.2.

Thanks for letting me know ;-)