Multiple varnish servers

ostark / upper

Integrates Edge Caches like Fastly, KeyCDN, Cloudflare and Varnish with Craft.

MIT License

102 stars 22 forks source link

Multiple varnish servers #25

Closed larsboldt closed 5 years ago

larsboldt commented 5 years ago

Does Upper support multiple varnish servers?

Can we do VARNISH_URL=http://1.1.1.1/,http://2.2.2.2 or something?

ostark commented 5 years ago

@larsboldt Not yet. Do you have a real use case for this?

larsboldt commented 5 years ago

Yes. We have multiple varnish servers and multiple craft cms backends, so we need this feature. We can submit a PR if you want.

larsboldt commented 5 years ago

But we can only test with Varnish ^

ostark commented 5 years ago

I'm happy to merge your PR - I never tested varnish properly. Also, include a fix for the prefix issue (just remove the second parameter, the default to - should do the trick)

larsboldt commented 5 years ago

Alright, will do.

ostark commented 5 years ago

Eventually released https://github.com/ostark/upper/commit/48f53b7dadb084ab9764678c53f6db7332cce82c thanks @larsboldt