search

ostat / gridfinity_extended_openscad

Gridfinity Extended OpenSCAD Model
https://docs.ostat.com/docs/openscad/gridfinity-extended
MIT License
159 stars 17 forks source link

[BUG] Drawers do not have boxes. #10

Closed Monniasza closed 7 months ago

Monniasza commented 7 months ago

When I enable baseplates on the drawer, the drawer does not have the bottom base, but throws a warning: Ignoring unknown module 'grid_block'. Please revert the base STL and my work workaround with tiling the base model. Also please merge the efficient shelves that I've made after you merged the PR.

ostat commented 7 months ago

This should be fixed. Can you get latest and let me know if you are still having issues? I also added some filament saving options to the walls. Feedback welcome. I would like to avoid requiring the STL unless we absolutely need to. As it reduces the options, like setting the base to half pitch. image

Monniasza commented 7 months ago

Your image looks okay. I'll check out the options. I'm using OpenSCAD version 2023.08.29 snapshot.

Monniasza commented 7 months ago

The pattern extends past the front and starts too far to the front. image

Monniasza commented 7 months ago

Here are my settings: gridfinity_drawers.json

Monniasza commented 7 months ago

On the left side of the drawer on the rear there should not be a hex pattern. image

ostat commented 7 months ago

I will take a look. I had shift the side cutout to stop it going out the back.

Good spot re the back will verify the math.

Not sure if you saw, I added an option to the drawers to remove the floor and just have the grid. If you fill it with bins you might not need the solid floor. Need to check if the bins would stick through and mess up the sliding action.

ostat commented 7 months ago

The wall coutout positioning is fixed in d64e655

Monniasza commented 7 months ago

@ostat The wall cutout positioning looks good. image

Monniasza commented 7 months ago

However, the model with hex pattern takes forever to slice on PHOEU computer.

ostat commented 7 months ago

I updated the model to allow for custom drawer sizer. It was more complex than expected, but I think I got there in the end. Would appreciate if you could review the changes in case I broke anything. image

Monniasza commented 7 months ago

I get lots of warnings and the drawer boxes do not appear, only the handles. I use the OpenSCAD version 2024.02.19.ai18569 image https://gist.github.com/Monniasza/8cce959ca7d661030b4a5329b9eec068

Monniasza commented 7 months ago

Additionally, the drawerslides should only extend so far as the user has defined, but they always cover the entire width of the chest.

Monniasza commented 7 months ago

You can define the inner dimensions of the drawers as a list.

ostat commented 7 months ago

Sorry had not pushed all the changes. Think I got them all now.

Monniasza commented 7 months ago

@ostat You have not said that setting drawer handle height to -1 makes it span the entire drawer height.

Monniasza commented 7 months ago

Vertical handles do not require supports, unlike horizontal handles.

ostat commented 7 months ago

We can prob close this now? I think all the issues are resolved.

I have a couple of other ideas.

I would like an option to swap drawers around when they are not the same size. Perhaps a small set (every 7mm) of runners that slides in to the walls of the drawer or chest? Though I'm a bit worried that the walls of the chest will flex too much.

Also I would like an option to have the chest fit in to the shape of a Gridfinity bin. But maybe this would need to be a different script, as it would confuse the settings.

Monniasza commented 7 months ago

@ostat You can close it, all three drawer box bugs have been fixed.