ostat / gridfinity_extended_openscad

Gridfinity Extended OpenSCAD Model
https://docs.ostat.com/docs/openscad/gridfinity-extended
MIT License
159 stars 17 forks source link

Support click lables #20

Open ostat opened 5 months ago

ostat commented 5 months ago

Add support for - Gridfinity Swappable Labels by Cullen J Webb

https://makerworld.com/en/models/446624#profileId-353132

ostat commented 5 months ago

image

Added in #f895207

gridfinity_cup_modules_with_click_label.zip

CullenJWebb commented 5 months ago

I printed the test bin, thanks so much for adding this.

The labels fit well enough that I would consider it a success, but the dimensions are off by enough that the all important "click" isn't as satisfying. I've added the fusion360 files for both the bins and the labels, but here are the dimensions for reference:

ostat commented 5 months ago

Thanks for taking the time to print the model out. I will try to adjust the ribs. I did them in a lazy way that is not very accurate. I will fix that up with more exact dimensions.

zerocle commented 4 months ago

I commented on MakerWorld, but figure this is probably the better place. First, these bins and labels are amazing, so thank you for adding support for the click labels. There are a couple of bugs I noticed,

  1. if the bin's split line intersects with the snap label, then the split will raise above the top of the label, interfering with the label placement
  2. if you extend the label to take up multiple widths, only the first width of label gets the snaps embedded.

For reference my settings that I changed were

ostat commented 4 months ago

@zerocle, Thanks for reporting. That is correct, there are a few complexities I need to resolve with the click labels.

The dividers is a bit tricky due to how I have written the code. (I would need to subtract the label from the divider, then subtract the label with click option from the bin space). One easy option might be to add a divider height option. This will allow the divider to be to be reduced below the click label height so it does not interfere. This might also be helpful for other situations.

Adding the click to other labels is something I have been meaning to do. I need to work out what to do if the label is not big enough to fit a standard click label. Perhaps @CullenJWebb has some ideas there?

CullenJWebb commented 4 months ago

@ostat - The click labels standard will always be the same size, however, I do think I have a solution for undersized space for labels.

undersized label 01

Here you can see that I've generated a bin with a label space of only 0.6u wide, whereas the click labels require at least 0.97u or something like that. I've added the click label slot negative volume and attached it over-hanging the edge.

When sliced it looks like this:

undersized label 02

There are 2 ribs remaining to click into, with space for the label to overhang the edge. This gives users the option to manually trim their labels in the slicer or with scissors irl, or even let them hang over the edge. The over-hang isn't required though and if it's easier to you to simply trim off the right edge that would be fine as well.

So here are my suggestions:

In short, I don't want to define a specific size for "mini" labels as we will always run into unique situations where somebody would prefer a larger or smaller label, and simply allowing them to trim to fit resolves all use cases for less than 1u width.

Also, as I mentioned to zerocle on Makerworld, I like the idea of multiple label slots per bin, especially full width label slots. I've attached screenshots here showing how I added 3 label slots to a 3u wide bin using the negative volumes again.

3 labels negative 01

That is the negative volumes being positioned, here is the sliced model:

3 labels negative 02

ostat commented 4 months ago

@CullenJWebb Some good ideas there. I will have a look and see what I can come up with. I think we can make some of that work.

One thought, The click labels hold in place using the triangle ribs. Did you consider instead integrating the click mechanism in to the long sides of the label? This should allow for a very similar click function without the need for the rib. Making the creating short and long label slots a lot easier. For a bin that was say three units wide, you could just have a single long slot along the label and someone could insert the click labels are they want.

CullenJWebb commented 4 months ago

@ostat Dang, that's a great idea. I will do some testing to see how well that works. I don't want to deprecate all of the bins people have already created so I need to be sure that this would be a worthwhile improvement with no downsides. I'll follow up with you on that.

CullenJWebb commented 3 months ago

I am discussing the change of the click label standard with ndevenish of gflabel. Feel free to add any thoughts you may have in that discussion, otherwise thank you for your patience while I redesign it.

Also, in case you are still working on implementing it, the name is going to be changed shortly to "Cullenect" labels to help differentiate the click labels from the click baseplates and lids already in the gridfinity ecosystem.