search

ostat / gridfinity_extended_openscad

Gridfinity Extended OpenSCAD Model
https://docs.ostat.com/docs/openscad/gridfinity-extended
MIT License
159 stars 17 forks source link

gridfinity_item_holder.scad - Add back label support #22

Closed jprisant closed 2 months ago

jprisant commented 5 months ago

Reference: https://github.com/ostat/gridfinity_extended_openscad/pull/12

This release removed support for labels. Please add them back. Fwiw, the files are so wildly and wonderfully flexible, might as well keep all the options [instead of removing them] for folks to use [or not] as desired.

abel = "disabled"; // ["disabled", "left", "right", "center", "leftchamber", "rightchamber", "centerchamber"]
// Width of the label in number of units, or zero means full width
label_width = 0;  // .01
vaz-ar commented 2 months ago

@jprisant I was looking into this issue to see if I could fix it, but from what I am seeing the label has been put back in the file already, could you confirm ?

ostat commented 2 months ago

@vaz-ar I think I have fixed it, but I have not really tested it. If you can confirm its working I am happy to close this one.

vaz-ar commented 2 months ago

Hi @ostat, from what I am seeing it looks the same as it did before #12 was merged (I went back to the commit before that), the only difference is that the label is now in a dedicated section in the openscad customizer.

ostat commented 2 months ago

I moved the label to its own section as it has more settings now. I think we can close this. Thanks for your help.