search

ostinelli / apnotic

A Ruby APNs HTTP/2 gem able to provide instant feedback.
MIT License
480 stars 96 forks source link

allow voip type #88

Open kelleyduran opened 5 years ago

kelleyduran commented 5 years ago

proposed fix for invalidpushtype error https://github.com/ostinelli/apnotic/issues/87

benubois commented 3 years ago

Hi @kelleyduran,

Thanks for your work on this!

What I'd like to see is a proper wrapper around the apns-push-type key, with an eye toward maintaining backward compatibility with background_notification?.

The .voip method is an interesting idea, but I think just specifying the value of apns-push-type with an attr_accessor of push_type would be the most consistent with the current API. In addition to voip, there's also alert, background, location, complication, fileprovider, mdm, so to be consistent, apnotic would have to offer a corresponding method for all of these, and be updated every time a new one is added.

I know it's been a long time so if you're not interested or available to do this work I would understand and we can close this PR.

Ben

dfabreguette commented 3 years ago

Hi, I need to setup voip push notifications. Is this going to be merged to master anytime ?