ostinelli / apnotic

A Ruby APNs HTTP/2 gem able to provide instant feedback.
MIT License
479 stars 94 forks source link

connection.join does not take any parameters like the documentation suggests. #96

Closed zrice57 closed 4 years ago

zrice57 commented 4 years ago

The push_async docs give an example with a join timeout:

# wait for all requests to be completed
connection.join(timeout: 5)

However, that method takes no parameters:

def join
    @client.join
end

I think this should look like

def join(timeout: nil)
    @client.join(timeout)
end
ostinelli commented 4 years ago

You are correct, but you are looking at the documentation in master. This hasn't been implemented yet, I will try and implement this in the fore-coming days and do a minor version bump.

zrice57 commented 4 years ago

Oh my mistake, thank you

ostinelli commented 4 years ago

Implemented and pushed.

patriciojofre commented 4 years ago

thank you, now it works perfectly