Open gus-bn opened 3 years ago
bump, needed very much
I also needed to send VoIP push notifications so I'm using the branch that @gustavobnmx created, it would be nice to have this merged into the main project. 👍
Hi @gustavobnmx,
Thanks for making this! I like the symmetry with custom_payload
. Having a way to merge in headers provides a valuable escape hatch to add anything without updates to apnotic.
Could the documentation be edited down to just demonstrate what is new around adding custom_headers? The new section feels redundant and the readme is already quite long.
After that would it be possible for you to squash your commits and force-push?
Finally, for voip
specifically, what I'd like to see is a proper wrapper around the apns-push-type
key, with an eye toward maintaining backward compatibility with background_notification?. However this does not need to hold up the merge of this pull request.
Is this going to be merged anytime soon? Would really help to solve sending VoIP push.
@bhishakBitcanny see @benubois previous remark, some work is pending for this to get merged. We welcome some help to close this if you're up for it!
apns-push-type
must be sent asvoip
content_available
for bg of alert values, the cleanest solution would be to allow overriding the request headers. This solution would also support:complication
andfileprovider
notifications.Usage:
Sources: