search

ostinelli / net-http2

NetHttp2 is an HTTP/2 client for Ruby.
MIT License
140 stars 31 forks source link

add ability to configure http-2 client #17

Closed Fivell closed 6 years ago

Fivell commented 7 years ago

hello, thanks for this gem, we experience HTTP2::Error::StreamLimitExceeded exception when using this gem with rpush. Looks like we need to configure settings_max_concurrent_streams option I noticed we can't configure http2 client using params for constructor https://github.com/igrigorik/http-2/blob/ea9cbd06d0e05641a5d6cfe2f31d584d3f839721/lib/http/2/connection.rb#L76

Any thoughts ? Thanks

ostinelli commented 7 years ago

https://github.com/ostinelli/net-http2/pull/22 has been just merged in. @benubois is showing how this can be used in Apnotic https://github.com/ostinelli/apnotic/commit/d5481eca2a3d45e3388b3e045f532eb7b08772bf

Does this help?