search

ostinelli / net-http2

NetHttp2 is an HTTP/2 client for Ruby.
MIT License
140 stars 31 forks source link

Need to synchronize around new_stream #35

Closed singpolyma-shopify closed 5 years ago

singpolyma-shopify commented 5 years ago

https://github.com/ostinelli/net-http2/blob/master/lib/net-http2/client.rb#L35

Everything else in this class seems designed to be thread-safe, but new_stream at very least uses and then increments a counter in an instance variable in http2 client, but is not wrapped in the mutex.