search

ostis-ai / sc-machine

Software implementation of semantic network storage
https://ostis-ai.github.io/sc-machine
Other
20 stars 22 forks source link

[kpm] Set system context for modules initialize #380

Closed NikitaZotov closed 3 months ago

NikitaZotov commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.21%. Comparing base (bc93a3b) to head (95c8ff1). Report is 1 commits behind head on main.

:exclamation: Current head 95c8ff1 differs from pull request most recent head 818522a

Please upload reports for the commit 818522a to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #380 +/- ## ========================================== - Coverage 95.25% 95.21% -0.05% ========================================== Files 202 202 Lines 18862 18878 +16 ========================================== + Hits 17967 17974 +7 - Misses 895 904 +9 ```
NikitaZotov commented 5 months ago

I dont like several identifiers.

  • s_memory_default_ctx in c code
  • ms_globalContext in c++ code
  • system context is what we call for it What is the difference? Can we name it in the same way?

It is not about this PR. s_memory_default_ctx is object in C, it satisfies the syntax of C. ms_globalContext is object in C++, is satisfies the syntax of C++. This objects has common class system context

NikitaZotov commented 4 months ago

I'm not talking about syntax. I'm talking about the meaning of the words default, global, system. Why not use the word system everywhere? How is it different from global and default?

https://github.com/ostis-ai/sc-machine/issues/383