Build system upgrades - Githubissues

ostis-ai / sc-machine

Software implementation of semantic network storage

https://ostis-ai.github.io/sc-machine

Other

20 stars 22 forks source link

Build system upgrades #406

Open FallenChromium opened 2 months ago

FallenChromium commented 2 months ago

[x] Read PR documentation
[ ] Update changelog
[x] Update documentation

Main changes:

The default way to manage build dependencies has been changed to Conan (we've used OS package managers before)
Consuming sc-machine as a library is now much more streamlined: adding it into the CMake tree isn't required anymore
Some groundwork has been made to make sc-component-manager more flexible

Rationale behind the changes: TBD

TO-DO before merging:

Depends on #404
TBD

FallenChromium commented 3 weeks ago

Current version of extensions path is borked since the current ld paths do not include a way for extensions to link to kpm-common

FallenChromium commented 1 day ago

Conan test fails because of the incompatibility of the older recipes of glib (prior to 2.76.3) and Python 3.12's policy to disallow system-wide package installations. Since downgrading user's python or mandating a .venv are no-gos I'd suggest bumping to a newer glib version or building an older glib version with the setuptools patch from the latest recipe. That said, we might not suffer from the upgrade if the symbols we use are abi-compatible with the older versions used in e.g. Ubuntu 22.04 (glib 2.72 is used there iirc)

codecov[bot] commented 22 hours ago

Codecov Report

Attention: Patch coverage is 98.96373% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.87%. Comparing base (485e349) to head (d088680). Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #406 +/- ## ========================================== - Coverage 95.67% 94.87% -0.81% ========================================== Files 232 236 +4 Lines 25709 25731 +22 Branches 1801 1802 +1 ========================================== - Hits 24596 24411 -185 - Misses 1113 1320 +207 ```