search

ostownsville / cordova-plugin-fcm

Google FCM Push Notifications Cordova Plugin
21 stars 17 forks source link

Fix issue to get value of node when have attributes #35

Open thanhnhan2tn opened 6 years ago

thanhnhan2tn commented 6 years ago

Fix error when the xml tag have attributes ex: <name short="AppName">appName</name>

kalashri-webonise commented 6 years ago

I have click_Action: 'FCM_PLUGIN_ACTIVITY' in the message which i am sending from server side. still onNotification() method is not getting executed on android.It is working fine on ios. Below are cordova versions in my application.

"dependencies": { "cordova-android": "^6.2.3", "cordova-google-api-version": "0.0.1", "cordova-ios": "^4.5.0", "cordova-plugin-fcm": "git+https://github.com/ostownsville/cordova-plugin-fcm.git", "cordova-plugin-geolocation": "2.1.0", "cordova-plugin-inappbrowser": "1.2.0", "cordova-plugin-network-information": "1.2.1", "cordova-plugin-screen-orientation": "~2.0.2", "cordova-plugin-splashscreen": "3.2.2", "cordova-plugin-streaming-media": "^1.0.2", "cordova-plugin-whitelist": "1" } I have tried all possible solution to get it resolve. Can someone help me with this.

thanhnhan2tn commented 6 years ago

Hi @kalashri-webonise ,You should create new question to https://stackoverflow.com instead comment to PR,

luigi37 commented 6 years ago

Hi Thanh Nhan, which issue is this code solving? Compilation problem with other plugins or...? Thanks

thanhnhan2tn commented 6 years ago

Hi @luigi37 this is fixed for when the app have difference short name.

appName

So I dont have another plugin now.

luigi37 commented 6 years ago

Thanks for explanation. Looks useful. I hope it gets merged.