search

ostreedev / ostree-rs-ext

Rust library with higher level APIs on top of the core ostree API
Apache License 2.0
72 stars 22 forks source link

Add support for zstd:chunked #608

Closed cgwalters closed 2 months ago

cgwalters commented 4 months ago

Should be a trivial patch

travier commented 4 months ago

From "rpm-ostree":

error: Importing: Unencapsulating base: Unhandled layer type: application/vnd.oci.image.layer.v1.tar+zstd
travier commented 4 months ago

Unfortunately https://github.com/ostreedev/ostree-rs-ext/pull/615 is for zstd only, not zstd:chunked which is not supported by the oci_spec library yet.

travier commented 4 months ago

For reference: https://github.com/containers/storage/pull/775

jmarrero commented 1 month ago

From "rpm-ostree":

error: Importing: Unencapsulating base: Unhandled layer type: application/vnd.oci.image.layer.v1.tar+zstd

I am seeing this on OCP 4.16 is there a fix that needs to be backported?

jmarrero commented 1 month ago

Also are we building images with application/vnd.oci.image.layer.v1.tar+zstd support? without supporting it yet on OCP or is it the podman version I used for the layered image?.. /me goes try rebuilding the image in RHEL.

travier commented 1 month ago

Looks like podman started pushing using zstd compression by default (?). We only have support for that in the latest rpm-ostree release AFAIK.

cgwalters commented 1 month ago

I am seeing this on OCP 4.16 is there a fix that needs to be backported?

Where? In Prow CI? Local builds? A customer bug?

Looks like podman started pushing using zstd compression by default (?).

Wait, really? That's going to cause some fallout for sure. I think this is probably from https://bodhi.fedoraproject.org/updates/FEDORA-2024-ab42dd0ffb

cgwalters commented 1 month ago

https://bodhi.fedoraproject.org/updates/FEDORA-2024-ab42dd0ffb#comment-3555202

jmarrero commented 1 month ago

I am seeing this on OCP 4.16 is there a fix that needs to be backported?

Where? In Prow CI? Local builds? A customer bug?

Using the clusterbot created cluster OCP 4.16-rc3 I was trying to help verify an issue that includes replacing the kernel and hit this with coreos layering.

I did build the image I am rebasing to using Fedora 40.

cgwalters commented 1 month ago

OK, in the meantime, the workaround for this is probably to do skopeo copy --dest-compress-format=gzip containers-storage:<local image> docker://quay.io/exampleuser/someuser

Or set compression_format = "gzip" in /etc/containers/containers.conf (locally) or revert the change in the /usr copy in custom images.

jmarrero commented 1 month ago

Thanks that skopeo command made everything better!